add another esimd example #2387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com> Signed-off-by: yanfeng xiao <yanfeng.xiao@intel.com> Co-authored-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
| @@ -0,0 +1,221 @@ | |||
| //==---------------- matrix_transpose.cpp - DPC++ ESIMD on-device test ----==// | |||
There was a problem hiding this comment.
This header is wrong.
Comment on lines
+20
to
+23
| #define NUM_BINS 256 | ||
| #define SLM_SIZE (NUM_BINS * 4) | ||
| #define BLOCK_WIDTH 32 | ||
| #define NUM_BLOCKS 32 |
There was a problem hiding this comment.
How about some C++?
Suggested change
| #define NUM_BINS 256 | |
| #define SLM_SIZE (NUM_BINS * 4) | |
| #define BLOCK_WIDTH 32 | |
| #define NUM_BLOCKS 32 | |
| static constexpr int NUM_BINS = 256; | |
| static constexpr int SLM_SIZE = NUM_BINS * 4; | |
| static constexpr int BLOCK_WIDTH = 32; | |
| static constexpr int NUM_BLOCKS = 32; |
| return 1; | ||
| } | ||
|
|
||
| class ESIMDSelector : public device_selector { |
There was a problem hiding this comment.
How about refactoring this class into a separate file or even put it along with other standard selectors to be available to users?
| << dev_type << "' is not.\n"; | ||
| return -1; | ||
| } | ||
| // If "SYCL_DEVICE_TYPE" not defined, only allow gpu device |
There was a problem hiding this comment.
Why so? If host device is supported, why not let select it automatically?
|
|
||
| HistogramCPU(input_size, input_ptr, cpu_histogram); | ||
|
|
||
| printf("finish cpu_histogram\n"); |
There was a problem hiding this comment.
C++?
Suggested change
| printf("finish cpu_histogram\n"); | |
| std::cout << "finish cpu_histogram\n"; |
| } | ||
| }; | ||
|
|
||
| int main(int argc, char *argv[]) { |
There was a problem hiding this comment.
You don't use them anyway.
Suggested change
| int main(int argc, char *argv[]) { | |
| int main() { |
jsji
pushed a commit
that referenced
this pull request
Mar 7, 2024
The Headers for this extension were published so we should use them instead: KhronosGroup/SPIRV-Headers@b73e168 Original commit: KhronosGroup/SPIRV-LLVM-Translator@7d7e0ac5303f93d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
histogram using SLM and 256 bins