-
Notifications
You must be signed in to change notification settings - Fork 24
Enums #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enums #45
Conversation
Thank you for the contribution Dan! I made some comments on areas for improvement. |
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Show resolved
Hide resolved
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
Can someone please check whether the file/directory names, slug/id and similar as well as the link to Switch Expressions are correct? I had to guess these since these articles/the |
And I can also squash the changes to a single commit if wanted. |
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Show resolved
Hide resolved
Yea if you can do that at the end. That makes reviewing this addition later easier. |
I have now made a few changes to the conclusion section in order to (hopefully) address @ammbra's feedback and make it easier to understand. |
I just want to mention that with this approach, I will not be able to squash it or do any changes in that branch so one of you would need to do this if needed. |
no problem you can work in your branch and I can update. I've changed the conclusion a bit, see if you like it. |
Can you merge the changes from main...danthe1st-enums into your branch so this PR is the active one? |
I have merged it as well as changed |
Thank you @danthe1st for your contribution and congrats on being the first approved community contribution! Once merged here we'll port it to the live site soon. Shoot me an email or Twitter DM and we'll arrange for a small thank you to be sent your way. |
in case you missed it https://dev.java/learn/classes-objects/enums/ |
Request issue
#40
I cannot self-assign to this issue since I don't have the necessary permissions.
Website section
Getting to Know the Language
>Classes and Objects
>Enums
Details
This PR adds an article on the topic of enums in Java.
It covers the following questions:
Since the
Classes and Objects
section is not present in this repository, it might be necessary to change the directory name, id or similar. For that reason, I have named the file01_enums.md
for now. Should I change that to09_enums.md
?Also, I am not sure on whether the id in the link for switch expressions is correct since that article seems to be missing from this repository as well.