Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all YAML FullLoader calls to SafeLoader #1285

Merged
merged 1 commit into from
Jul 3, 2021

Conversation

micahellison
Copy link
Member

The pyyaml project has some security issues with its FullLoader. It's not a huge deal for jrnl users, given that it's from the config file rather than untrusted input (such as user supplied data to a web server), but since all the tests are passing with SafeLoader, there's no harm in switching to this.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥔

@wren wren merged commit 9e31534 into jrnl-org:develop Jul 3, 2021
@wren wren added the build Issues related to the build pipeline label Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants