Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '-not' flag for excluding tags from filter #637

Merged
merged 2 commits into from
Sep 21, 2019

Conversation

jprof
Copy link

@jprof jprof commented Jul 29, 2019

This change adds a new flag to exlude all tags after it. A rough example:

-> jrnl @wat --short
2019-07-25 18:16 @todo @wat wat2
2019-07-27 18:25 @todo @wat @not test
2019-07-28 21:54 @todo @wat wat2
-> jrnl @wat -not @not --short
2019-07-25 18:16 @todo @wat wat2
2019-07-28 21:54 @todo @wat wat2

@jprof jprof mentioned this pull request Jul 29, 2019
@wren wren added the enhancement New feature or request label Aug 3, 2019
@wren
Copy link
Member

wren commented Aug 3, 2019

This is looking good. Can you please add some tests for this? The tests can be the examples that you posted in this PR.

@jprof
Copy link
Author

jprof commented Aug 8, 2019

This is looking good. Can you please add some tests for this? The tests can be the examples that you posted in this PR.

Thanks @wren, I actually was not familiar with behave so I didn't know there were tests until your comment. Would you be willing to take an update to the CONTRIBUTING file to demonstrate how it is used? I'd be happy to open a new PR if so.

@wren
Copy link
Member

wren commented Aug 9, 2019

I think that's a good idea. We have an milestone to update documentation, so we should include this in that.

@wren wren added this to the v2.0.1 milestone Sep 6, 2019
@wren wren merged commit b8a2c2d into jrnl-org:master Sep 21, 2019
@wren
Copy link
Member

wren commented Sep 21, 2019

@jprof Thank you!

@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request 🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants