Add tags to json and xml exporters #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do note that I fixed a poorly written step in 951a4a3. It was part of my original hacked xml test, but I ended up writing my own step. |
wren
reviewed
Jun 6, 2020
features/exporting.feature
Outdated
| @@ -9,6 +9,8 @@ Feature: Exporting a Journal | |||
| And "tags" in the json output should contain "@idea" | |||
| And "tags" in the json output should contain "@journal" | |||
| And "tags" in the json output should contain "@dan" | |||
| And entry 1 should have an array called "tags" with 2 elements | |||
There was a problem hiding this comment.
Minor nitpick:
The use of the word "called" in our tests always means that we are invoking something (like the jrnl app itself). Can you take out the word here to avoid confusion?
So, it should just read "entry 1 should have an array "tags" with 2 elements`.
|
@wren done. |
wren
pushed a commit
that referenced
this pull request
Jul 25, 2020
* tag array for json * add tags to entry in xml * xml test * json test * black * removed called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to close #974.
It is nice to have the tags separately by entry rather than just a frequency chart which is somewhat useless except for perhaps interesting statistics.
The only exporters that support this kind of structure is JSON, XML, and YAML. YAML already has this feature.
This PR adds individually tagged entries for both xml and json.
Checklist
for the same issue.