-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threading configuration; #63 Fix for read-race condition #74 #74
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks ok but can you split this up a little more into separate PRs to ease the review?
version = "0.9.0" | ||
authors = ["Ka-Hing Cheung <khc@hxbc.us>"] | ||
version = "0.9.1" | ||
authors = ["Ka-Hing Cheung <khc@hxbc.us>", "Joshua Pedrick <joshua.pedrick@gmail.com>"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this and the version change.
@@ -48,6 +50,7 @@ pub fn to_cstring(path: &dyn AsRef<Path>) -> CString { | |||
return CString::new(bytes).unwrap(); | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded whitespace
No description provided.