Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

show links#133

Merged
makew0rld merged 3 commits intomakew0rld:masterfrom
p1gp1g:show_links
Dec 1, 2020
Merged

show links#133
makew0rld merged 3 commits intomakew0rld:masterfrom
p1gp1g:show_links

Conversation

@p1gp1g
Copy link
Contributor

@p1gp1g p1gp1g commented Nov 30, 2020

No description provided.

@makew0rld
Copy link
Owner

I'm not sure what this PR adds. It seems like link lines would become quite long like this. Personally if want to view the URL, I use the Tab and Shift-Tab keys. You can use Esc to stop selecting. What do you think?

@p1gp1g
Copy link
Contributor Author

p1gp1g commented Nov 30, 2020

Actually, I really don't like to clic on a link I haven't seen. The miss of this is even blocking for me. And I prefer to navigate with <space>+N°. For the moment I haven't seen a link written on 2 lines.

I knew it would not be the choice of every body, that's why I set the default to false.

@makew0rld
Copy link
Owner

Alright. Please add the config changes to default-config.toml as well, and change the line that reads linkText = linkText + " (" + url + ")" to linkText += " (" + url + ")" instead. Thanks!

@makew0rld makew0rld merged commit cafbb5c into makew0rld:master Dec 1, 2020
@makew0rld
Copy link
Owner

Thanks, merged.

@p1gp1g
Copy link
Contributor Author

p1gp1g commented Dec 1, 2020

Thanks :)

makew0rld added a commit that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants