Fix Bookmarks modal not closing on ESC#173
Merged
makew0rld merged 1 commit intomakew0rld:masterfrom Feb 4, 2021
Merged
Conversation
Owner
|
Thanks! I didn't think of this, but it's handy. Could you add this for other modals too? And update Self-note: Update wiki about this as well. |
Contributor
Author
|
AFAICT all the other modals already close on ESC. I tested it specifically for the Subscription and Input modal. The code for the other modals also seems like they should close. Note added to |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.