Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

fix: remove overly broad VAT error catch that could swallow legitimate failures#36

Merged
marcusquinn merged 1 commit intomainfrom
fix/vat-error-specificity
Mar 7, 2026
Merged

fix: remove overly broad VAT error catch that could swallow legitimate failures#36
marcusquinn merged 1 commit intomainfrom
fix/vat-error-specificity

Conversation

@marcusquinn
Copy link
Owner

Summary

  • Removes the catch-all error.message.includes("VAT") condition from the VAT obligations error handler that could silently swallow legitimate API errors (e.g. "VAT service unavailable") and present them as successful empty results
  • Keeps only the two specific conditions ("not VAT registered", "MTD not configured") that indicate a known account configuration issue

Context

Addresses review feedback from Gemini Code Assist on PR #26 (captured in issue #31). The broad "VAT" substring match was added as a safety net but is too permissive — it masks errors that should propagate to the user.

Closes #31

…e failures

Remove the catch-all error.message.includes("VAT") condition that could
silently swallow legitimate errors like "VAT service unavailable" and
present them as successful empty results. Keep only the two specific
conditions ("not VAT registered", "MTD not configured") that indicate
a known configuration issue.

Closes #31
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 21 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bdba576a-6c25-4366-ab6f-eb13ac2e24df

📥 Commits

Reviewing files that changed from the base of the PR and between 1c5f74a and b587753.

📒 Files selected for processing (1)
  • src/tools/report.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/vat-error-specificity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2026

@marcusquinn
Copy link
Owner Author

This PR appears orphaned — no active worker process found and no activity for 6+ hours. The linked issue is already closed. Flagging for review. If work is still in progress, remove the status:orphaned label.

@marcusquinn
Copy link
Owner Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@marcusquinn marcusquinn merged commit 425ebf2 into main Mar 7, 2026
8 checks passed
@marcusquinn marcusquinn deleted the fix/vat-error-specificity branch March 7, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quality-debt: src/tools/report.ts — PR #26 review feedback (medium)

1 participant