fix: remove overly broad VAT error catch that could swallow legitimate failures#36
Conversation
…e failures
Remove the catch-all error.message.includes("VAT") condition that could
silently swallow legitimate errors like "VAT service unavailable" and
present them as successful empty results. Keep only the two specific
conditions ("not VAT registered", "MTD not configured") that indicate
a known configuration issue.
Closes #31
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
This PR appears orphaned — no active worker process found and no activity for 6+ hours. The linked issue is already closed. Flagging for review. If work is still in progress, remove the |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|



Summary
error.message.includes("VAT")condition from the VAT obligations error handler that could silently swallow legitimate API errors (e.g. "VAT service unavailable") and present them as successful empty results"not VAT registered","MTD not configured") that indicate a known account configuration issueContext
Addresses review feedback from Gemini Code Assist on PR #26 (captured in issue #31). The broad
"VAT"substring match was added as a safety net but is too permissive — it masks errors that should propagate to the user.Closes #31