-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Edge version that supports exponentiation #1153
Conversation
I've added the version of edge that supports the exponentiation operation which is EDGE 13. I've added this based on this source http://news.thewindowsclub.com/microsoft-introduces-edgehtml-13-80893/
I thought this would be Edge 14, c.f. https://developer.microsoft.com/en-us/microsoft-edge/platform/changelog/desktop/14279/ cc'ing @erikadoyle to confirm the correct version here. |
Yup, it was introduced in EdgeHTML 14. Thanks @svijaykoushik for adding it in! |
@Elchi3 & @erikadoyle according to the change log on Build 10547 of Windows 10 Edge 13 added exponentiation operator as an experimental feature. On Edge 14 they added it in the main stream app. So, my question is which is the right version to add to the repo? |
Ah, good point. I think the release version where the feature is enabled by default is probably the most useful. Our features behind experimental flags are subject to code churn / bugs, so probably not reliably stable for mainstream use. (Also they would require end-users to toggle those flags in order to work). |
I've updated the correct version number of Edge for exponentiation operator support after review
@erikadoyle Yes, you are correct. The version where the feature is enabled by default would be useful. So, I've changed the version number on the JSON to "14" and committed the change. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @svijaykoushik!
Thank you @svijaykoushik! |
Thank you guys for guiding me |
I've added the version of edge that supports the exponentiation operation which is EDGE 13. I've added this based on this source . It was previously missing in this file.