Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 878820 - Contacts imported from VCF files disappear [r=arcturus] #10600

Merged
merged 1 commit into from
Jun 25, 2013

Conversation

sergi
Copy link
Contributor

@sergi sergi commented Jun 25, 2013

  • Using mozContacts now
  • Isolated functionality to make it easier to test
  • Added Unit tests
  • Not considering 'photo' field

- Using mozContacts now
- Isolated functionality to make it easier to test
- Added Unit tests
@sergi
Copy link
Contributor Author

sergi commented Jun 25, 2013

In the previous review of this issue, there was an error with photo fields. It turns out that all the API docs and tests in Gaia (!!) are doing the wrong thing when assigning values to the photo property of a mozContact object. The value of photo HAS to be a Blob, and not a String. Upon pointing this out, some API docs have been corrected, but many tests in Gaia are not (yet).

Since there is another issue regarding Vcard photo import (https://bugzilla.mozilla.org/show_bug.cgi?id=885545), I will tackle that one and add photo importing there. For now, photo importing for the contact is disabled since it was wrong anyway.

/cc @arcturus

@arcturus
Copy link
Contributor

Test for vcard passing for me locally.

Code already reviewed, r+

Thanks @sergi for the work!

sergi added a commit that referenced this pull request Jun 25, 2013
Bug 878820 - Contacts imported from VCF files disappear [r=arcturus]
@sergi sergi merged commit cc91e29 into mozilla-b2g:master Jun 25, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants