No expect of EAGAIN from sysread #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, submitted without writing description. |
IO#sysread doesn't raise EAGAIN, it's a blocking method. Use select(2) every time to check fd states before read(2). The removed loop could get blocked infinitely at a second run.
sorah
added a commit
to sorah/sorah-overlay
that referenced
this pull request
Feb 26, 2017
|
Errno::EAGAIN was originally for read_nonblock #7. And I agree that now the rescue is obsolete and loop should be omitted. Thanks. |
|
oh, I see. @eagletmt let me know if I miss something concerns. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.