-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data #10247
Merged
michael-radency
merged 6 commits into
master
from
node-1539-fix-expressions-in-webhook-nodesform-webhook-to-access
Aug 1, 2024
Merged
fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data #10247
michael-radency
merged 6 commits into
master
from
node-1539-fix-expressions-in-webhook-nodesform-webhook-to-access
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix-expressions-in-webhook-nodesform-webhook-to-access
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Jul 30, 2024
…fix-expressions-in-webhook-nodesform-webhook-to-access
…ssions-in-webhook-nodesform-webhook-to-access
netroy
changed the title
fix: Fix expressions in webhook nodes(Form, Webhook) to access previous node's data
fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data
Aug 1, 2024
netroy
approved these changes
Aug 1, 2024
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-1539-fix-expressions-in-webhook-nodesform-webhook-to-access
branch
August 1, 2024 08:22
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 1, 2024
* master: refactor(core): Decouple workflow created, saved, deleted events from internal hooks (no-changelog) (#10264) fix(core): Fix oauth2 callback and add integration tests (no-changelog) (#10272) fix(n8n Form Trigger Node): Improve copy and a few tweaks (no-changelog) (#10243) fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data (#10247) refactor(core): Port endpoints config (no-changelog) (#10268) feat(AWS Lambda Node): Add support for paired items (no-changelog) (#10270) fix: Loop node no input data shown (#10224) fix(core): Make OAuth1/OAuth2 callback not require auth (#10263) 🚀 Release 1.53.0 (#10266) fix(core): Upgrade @n8n/vm2 to address CVE‑2023‑37466 (#10265) feat(Calendly Trigger Node): Add OAuth Credentials Support (#10251) test(core): Improve and expand log streaming tests (no-changelog) (#10261) refactor(editor): Migrate `WorkflowExecutionsListView.vue` to composition API (no-changelog) (#10198) fix(core): Restore log event `n8n.workflow.failed` (#10253) test(core): Stop showing JWT warning during test runs (no-changelog) (#10255) fix(Postgres Node): Expressions in query parameters for Postgres executeQuery operation (#10217) fix(editor): Fix workflow execution list scrolling after filter change (#10226)
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trying to use expression like
{{ $json.someProp }}
in Wait node, when using Form resume mode, resolves in error thrownResolve
$execution
in Wait nodeRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1539/fix-expressions-in-webhook-nodesform-webhook-to-access-previous-nodes