Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'a HTTP' to 'an HTTP' to match #492 #495

Conversation

johado
Copy link
Contributor

@johado johado commented Nov 13, 2024

No description provided.

@venki5685
Copy link
Contributor

@johado, I am fine with this editorial changes, the main reason I did not do this change after your review is, original I used "an HTTP" in the PR, and it is changed to "a HTTP" after review comments from @kieran242 . @Kirean242 are you fine with this change i.e "an HTTP" from "a HTTP"?

@venki5685 venki5685 requested a review from kieran242 November 14, 2024 09:43
Copy link
Contributor

@venki5685 venki5685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@HansBusch HansBusch merged commit b08d354 into onvif:video/audio-clip-management Nov 27, 2024
Copy link
Contributor

@kieran242 kieran242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@venki5685 Totally ok with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants