Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Histogram distribution text and E(x) formula #28

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix Histogram distribution text and E(x) formula #28

wants to merge 6 commits into from

Conversation

rakhimov
Copy link
Member

The Histogram distribution is reviewed to correct the formula and the text in general.
Confusing use of x and E is avoided;
instead, conventional b for boundaries and w for weights are used in the formulas and text.

Fixes #27

@rakhimov rakhimov added this to the v2.1.0 milestone Dec 21, 2016
@rakhimov rakhimov force-pushed the histogram branch 4 times, most recently from 45c86fb to d4e164d Compare December 21, 2016 13:54
@rakhimov rakhimov mentioned this pull request Dec 22, 2016
Open
@rakhimov rakhimov force-pushed the histogram branch 5 times, most recently from 7812584 to dded0b7 Compare December 22, 2016 11:55
@rakhimov rakhimov requested a review from a user February 26, 2017 20:10
@rakhimov rakhimov force-pushed the histogram branch 2 times, most recently from 74b0f69 to 1e5a29a Compare April 23, 2017 08:28
@rakhimov
Copy link
Member Author

The html result can be viewed from artifacts.

@rakhimov
Correct the Histogram expected value formula
65b0044 
The confusing E_i is swapped for w_i for weights.
@rakhimov
Swap 'x' with 'b' for Histogram boundary notation
e42058f 
The x is confusing in this context
due to conventional use of x as the random variable
(result of sampling).
@rakhimov
Add Histogram distribution density function
1a32eb9
@rakhimov
Update the definition of Histogram distribution
aa4546c 
The range is fixed to be right-exclusive
as customary in other distribution sampling.
@rakhimov
Fix Histogram distribution sampling description
9b58b6b 
The two steps were confused in the sampling description.
The steps are rearranged and clarified.
@rakhimov
Fix (Cumulative|Discrete) => Histogram description
7dc1a81 
The =>Histogram formulas are fixed.
The text looks very confusing and out-of-place,
being a sign that these distributions should be provided separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhibti mhibti Awaiting requested review from mhibti

@AntoineRauzy AntoineRauzy Awaiting requested review from AntoineRauzy

@cfolleau cfolleau Awaiting requested review from cfolleau

@emelendez-csn emelendez-csn Awaiting requested review from emelendez-csn

@MichelBatteux MichelBatteux Awaiting requested review from MichelBatteux

@friedlhu friedlhu Awaiting requested review from friedlhu

@RobertoHerrero RobertoHerrero Awaiting requested review from RobertoHerrero

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
help wanted stochastic
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rakhimov