Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified #23354

Open
wants to merge 1 commit into
base: jdk24
Choose a base branch
from

Conversation

iklam
Copy link
Member

@iklam iklam commented Jan 29, 2025

Hi all,

This pull request contains a backport of commit d266ca96 from the openjdk/jdk repository.

The commit being backported was authored by Ioi Lam on 29 Jan 2025 and was reviewed by Aleksey Shipilev and Dan Heidinga.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23354/head:pull/23354
$ git checkout pull/23354

Update a local copy of the PR:
$ git checkout pull/23354
$ git pull https://git.openjdk.org/jdk.git pull/23354/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23354

View PR using the GUI difftool:
$ git pr show -t 23354

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23354.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2025

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 29, 2025

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified

Reviewed-by: lfoltan, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d266ca965d214f54c1ab16c1863f87728542b3e0 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified Jan 29, 2025
@openjdk
Copy link

openjdk bot commented Jan 29, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 29, 2025
@openjdk
Copy link

openjdk bot commented Jan 29, 2025

@iklam The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 29, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2025

Webrevs

Copy link
Member

@lfoltan lfoltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Lois

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 29, 2025
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-runtime hotspot-runtime-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants