[MCP Integration] Phase 2: Data models and constants#2235
Draft
aniruddh-alt wants to merge 9 commits intoani/mcp-integration-01-scaffoldfrom
Draft
[MCP Integration] Phase 2: Data models and constants#2235aniruddh-alt wants to merge 9 commits intoani/mcp-integration-01-scaffoldfrom
aniruddh-alt wants to merge 9 commits intoani/mcp-integration-01-scaffoldfrom
Conversation
|
Important Upgrade your plan to unlock code review, CI analysis, custom rules, and more. |
f38a2e4 to
8e7a6b1
Compare
70e68d6 to
b35dc2d
Compare
cbe787c to
4d3461e
Compare
b35dc2d to
79de029
Compare
Add Pydantic models (JobRecord, PreFlightSummary, CloudValidation, etc.) and constants (cloud provider configs, resource specs, validation rules) that form the shared foundation for all MCP services. Part of the MCP integration PR chain (Phase 2 of 10). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add missing "eval" to DATA_SPLITS constant - Convert mutable list constants to tuples - Import TypedDict from typing (Python 3.12+)
4d3461e to
89c8856
Compare
Pydantic requires typing_extensions.TypedDict (not typing.TypedDict) on Python < 3.12 when NotRequired fields are present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the MCP Integration PR chain (Phase 2 of 10) - Stage: foundation
What changed: Added Pydantic data models (
JobRecord,PreFlightSummary,CloudValidation, etc.) and constants (cloud provider configs, resource specs, validation rules) used by all MCP services.Why: These shared types and constants form the foundation that all subsequent service modules depend on.
Related issues
Before submitting