Semantic distinction between an IDENT and a STRING within the CSSExpressionMemberTermSimple

[shagkur]

It'd quite useful to be able to distinct between an IDENT and a STRING on CSSExpressionMemberTermSimple member (needed for instance for the image() function, where one can pass a url as a simple string literal along with a color to be used, i.e. image('dark.png', blue))
This distinction might be useful at ohter places too.

[phax]

That's a tricky one, because that means, that I need to use different data types internally, which will bloat the data model a bit more. But I can understand why it would make sense. As a heurisitc you can say everything that starts with ' or " is a String, whereas the other things are identifiers. Does that help? I could also provide you with a quick sanity method in CSSExpressionMemberTermSimple if needed...

[shagkur]

That's what i acutally do, i check whether the value is surrounded by ' or " to identify it as a String. I ofcourse understand your concerns, and i already realized this is being a rather big change.
Perhaps having an enum, whether it's a String or an Ident value in the CSSExpressionMemberTermSimple, which is resolved upon construction of this member would already help?

[shagkur]

Here's a PR (if you like)
#76

[phax]

Thanks for providing this patch - is that urgent for you? Than I can build a 6.4.2 version

[shagkur]

No worries. Do you normal release schedule. I can work with my fork. In the long run, i once want to switch to your release build rather than using the local fork.
Thanks alot for your quick reaction on all these issues & PRs i put :)

[phax]

Great thanks. Closing this issue for now.