Add support for @footnote area in @page #64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we use ph-css as part of a product that uses CSS for generating print layouts. In this use case we also need to support footnotes as defined in this w3c working draft: https://www.w3.org/TR/css-gcpm-3/
However parsing CSS files that use this kind of structure, failed with ph-css:
In the grammar I added @footnote just like the other page margins even if it not a margin per se but a page area. From a CSS point of view however I think this is fine, as it does behave like a page margin.
I also added a test css file and a test, that the file is read correctly. Is test css file read by the general tests as well or is there another place to register this test file?
The other extensions from this working draft (
::footnote-call
and::footnote-marker
) should already work I assume. Do you see any problems with them?