Narrow DOMDocument::createElement() return type and throw type for valid constant names#5192
Open
janedbal wants to merge 3 commits intophpstan:2.1.xfrom
Open
Narrow DOMDocument::createElement() return type and throw type for valid constant names#5192janedbal wants to merge 3 commits intophpstan:2.1.xfrom
janedbal wants to merge 3 commits intophpstan:2.1.xfrom
Conversation
Collaborator
|
You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x. |
staabm
reviewed
Mar 10, 2026
staabm
reviewed
Mar 10, 2026
|
|
||
| public function isMethodSupported(MethodReflection $methodReflection): bool | ||
| { | ||
| return extension_loaded('dom') && $methodReflection->getName() === 'createElement'; |
Contributor
There was a problem hiding this comment.
I am not sure whether this kind of optional runtime dependency is a good thing to have.
would it make sense to hard-code a list of valid elements instead?
Contributor
Author
There was a problem hiding this comment.
This logic was basically copied from SimpleXMLElementXpathMethodReturnTypeExtension, so I just followed that one.
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
Mar 10, 2026
Removes the implicit DOMException throw point when all constant string arguments are valid XML element names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#13792