Fix CI installing latest typescript #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the latest typescript is installed without a package-lock.json file. This file should be checked in so that the whole dependency tree is deterministic (see: https://nodejs.dev/learn/the-package-lock-json-file). Dont worry as this package-lock will not be used by npm when this package is used as a dependency in other packages.
This PR pins
typescript
to 4.3.x as typescript 4.4 has a semi-breaking change where they changecatch
argument from error tounknown
(see: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables).