-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(python): Fix test for new deltalake release #18211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ion-elgreco Thanks! That fixes one of the tests, there is one more still failing - test_write_delta
. It complains that a file already exists, probably because it's not overwriting correctly?
@stinodego ah didn't see that one, one sec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Good to merge if CI is green.
Seems more tests are incompatible, will. Compile it locally and run it |
There seem to be some differences between Linux / Windows 🤔 first Windows failed and Linux passed, now it's the other way around. |
Ah yes that's because Linux wheels for 0.19 failed, due to some issue with maturin, I am waiting on my PR to be merged in delta-rs so I can re release them |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18211 +/- ##
==========================================
- Coverage 80.30% 80.29% -0.01%
==========================================
Files 1498 1497 -1
Lines 198751 198741 -10
Branches 2833 2837 +4
==========================================
- Hits 159598 159579 -19
- Misses 38626 38635 +9
Partials 527 527 ☔ View full report in Codecov by Sentry. |
@stinodego tests should be fine now, did a local compile with a deltalake v0.19. I'll ping you when I fixed our python wheels |
e15e71b
to
ddb4b2a
Compare
We need to explicitly provide overwrite mode when setting overwrite_schema = True
@stinodego :)