Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hold string cache in new streaming engine and fix row-encoding #21039

Merged
merged 7 commits into from
Feb 3, 2025

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Feb 1, 2025

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Feb 1, 2025
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 70.32967% with 27 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (98ccb09) to head (5a01b75).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...es/polars-core/src/chunked_array/ops/row_encode.rs 68.85% 19 Missing ⚠️
crates/polars-core/src/series/mod.rs 58.82% 7 Missing ⚠️
crates/polars-expr/src/groups/row_encoded.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21039      +/-   ##
==========================================
+ Coverage   79.21%   79.27%   +0.06%     
==========================================
  Files        1583     1585       +2     
  Lines      225545   225611      +66     
  Branches     2586     2588       +2     
==========================================
+ Hits       178664   178857     +193     
+ Misses      46291    46164     -127     
  Partials      590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

The uncompressed lib size after this PR is 38.7352 MB.

@pola-rs pola-rs deleted a comment from github-actions bot Feb 3, 2025
@pola-rs pola-rs deleted a comment from github-actions bot Feb 3, 2025
@pola-rs pola-rs deleted a comment from github-actions bot Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

The uncompressed lib size after this PR is 38.7312 MB.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

The uncompressed lib size after this PR is 38.7216 MB.

@ritchie46 ritchie46 changed the title feat: Hold string cache in new streaming engine feat: Hold string cache in new streaming engine and fix row-encoding Feb 3, 2025
@ritchie46 ritchie46 merged commit 0cb0746 into main Feb 3, 2025
29 checks passed
@ritchie46 ritchie46 deleted the cat branch February 3, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant