fix: Return empty string from which_ide() when no IDE detected#172
Merged
fix: Return empty string from which_ide() when no IDE detected#172
Conversation
`which_ide()` implicitly returned NULL when no IDE environment variable matched, causing `nzchar(NULL)` to produce `logical(0)` and crash `if()` in `btw_app()`. Fixes #168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168
Summary
which_ide()implicitly returnedNULLwhen no IDE environment variable matched (outside Positron, RStudio, or VS Code). Inbtw_app(),nzchar(NULL)produceslogical(0), which crashesif()with "argument is of length zero".The fix makes
which_ide()return""as its default, ensuringnzchar()always receives a scalar string. The now-redundant%||% ""guard inwhich_ide_title()is also removed.Verification