-
Notifications
You must be signed in to change notification settings - Fork 12
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: postgres/pgcommitfest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d17a0a8
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: postgres/pgcommitfest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e797461
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 12 commits
- 26 files changed
- 2 contributors
Commits on Jan 12, 2025
-
This adds our own custom replication between the CFbot and the commitfest app. We currently keep the last CFbot runs in our database, in an attempt to keep the queries easy and efficient. The CFbot results are now shown on the overview page of each commitfest, as well as on the page for each specific patch.
Configuration menu - View commit details
-
Copy full SHA for 2796367 - Browse repository at this point
Copy the full SHA 2796367View commit details -
Integrate previous CFbot links with new code
In previous commits (2ada851 & b6010e9) some initial links and git checkout instructions were added to the patch page. I received some in person feedback at PgConf EU that those used quite some vertical space on the page. Now that we have a dedicated row in the table for CFbot statuses, it seems natural to integrate those previous links and checkout instructions into that row. Both to keep all CFbot content together, as well as to reduce vertical space needed. To reduce the necessary space needed for the checkout instructions, these previously explicit checkout instructions have been changed to button that copies the required commands to the clipboard. Finally, this also makes "Needs rebase!" link to CFbot logs instead of CI results. I updated these logs recently on the CFbot side to become much more useful to look at, by making them actually show the conflicts.
Configuration menu - View commit details
-
Copy full SHA for 8e33e1e - Browse repository at this point
Copy the full SHA 8e33e1eView commit details -
Make CFbot add a history item when patch needs rebase
This is needed to send notifications to a patch author that it subscribed. We don't send updates to other subscribers to the patch, as this information is generally only useful for the author themselves. By using the "history item" infrastructure it's also displayed on the patch page in the "History" table. That seems quite useful too, because it makes it clear how long the patch has needed a rebase.
Configuration menu - View commit details
-
Copy full SHA for 6a96e78 - Browse repository at this point
Copy the full SHA 6a96e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0fa12e - Browse repository at this point
Copy the full SHA a0fa12eView commit details -
This is mostly useful to avoid people from adding trailing whitespace to files.
Configuration menu - View commit details
-
Copy full SHA for b697c34 - Browse repository at this point
Copy the full SHA b697c34View commit details
Commits on Jan 13, 2025
-
Add ID column to commitfest page
The ID of a CF entry is the only stable identifier (people can change the name). That's why tooling such as CFbot uses the ID of the patch for a lot of things (including showing it on the cfbot overview page). Having it visible on the page is quite useful for debugging purposes In eee60a5 the ID was added to the title of the entry, but that made the the title of the page itself less prominent. So this is an attempt to have the information available, but not too prominently visible.
Configuration menu - View commit details
-
Copy full SHA for 0fc3c96 - Browse repository at this point
Copy the full SHA 0fc3c96View commit details -
If the commitfest entries are sorted by a column clicking the header again will now remove the sort. In a future commit, it would be nice to also support for reverse sorting.
Configuration menu - View commit details
-
Copy full SHA for 26e7222 - Browse repository at this point
Copy the full SHA 26e7222View commit details -
It was pretty confusing that clicking the patch name header would sort by created time, grouped by topic. This makes that sort by name.
Configuration menu - View commit details
-
Copy full SHA for ec78e45 - Browse repository at this point
Copy the full SHA ec78e45View commit details -
Allow sorting using the header of the closed patches too
Sorting order impacts closed patches too. So not showing the arrow that indicates sort direction on that header is confusing. While we're at it, we might as well allow people to toggle sorting direction using that header too. This also automatically fixes the problem that the cell in the closed patches header did not contain any title at all.
Configuration menu - View commit details
-
Copy full SHA for a1c4415 - Browse repository at this point
Copy the full SHA a1c4415View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4dff24 - Browse repository at this point
Copy the full SHA b4dff24View commit details -
Make /patch/{id} the URL for a patch
Previously we'd include the ID of the commitfest in the URL of the patch. In 9f12a5e we introduced a stable URL for patches that would redirect to the one for the latest commitfest. This starts to use that URL as the valid only URL for a patch (with the previous URL redirecting to this one). The reasoning behind this is that the old approach resulted in N different URLs for each patch, which all showed the exact same patch information. The only difference between all these URLs would be the breadcrumb at the top of the page. The only benefit of that approach is that if you're on an old commitfest, and click a link there, then the breadcrumb will bring you back to where you came from. Since people rarely have a reason to browse closed commitfests, the that benefit seems pretty small. Especially because people can just as well press their browser back button, in that case. The problems that these N links cause seem much more impactful to most users: 1. If you click an old link to a cf entry (e.g. one in the email archives), then the breadcrumb will contain some arbitrarily old commitfest. It seems much more useful to have the breadcrumb show the commitfest that the patch is currently active in (or got committed/rejected in). 2. Places that use the stable URLs require an extra round-trip to actually get to the patch page. 3. It's a bit confusing that old pages of a patch still get updated with all the new information, i.e. why have all these pages if they contain the exact same content. 4. Problem 3 is generally also bad for Search Engine Optimization (SEO), for now we don't care much about that though. Finally this also changes the links on the patch page itself for each of the commitfests that a patch has been part of. Those links were already rather useless, since all they effectively did was change the breadcrumb. But with this new commit, they wouldn't even do that anymore, and simply redirect to the current page. So now they start pointing to the commitfest itself, which seems more useful behaviour anyway.
Configuration menu - View commit details
-
Copy full SHA for bf5f948 - Browse repository at this point
Copy the full SHA bf5f948View commit details -
Configuration menu - View commit details
-
Copy full SHA for e797461 - Browse repository at this point
Copy the full SHA e797461View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff d17a0a8...e797461