[PGPRO-5255] fix that ALTER TABLE IF EXISTS ... RENAME TO of not exis… #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted table generate ERROR instead of NOTICE
ziva777
reviewed
Jun 28, 2021
src/utility_stmt_hooking.c
Outdated
| @@ -175,7 +175,10 @@ is_pathman_related_table_rename(Node *parsetree, | |||
| /* Fetch Oid of this relation */ | |||
| relation_oid = RangeVarGetRelid(rename_stmt->relation, | |||
| AccessShareLock, | |||
| false); | |||
| rename_stmt->missing_ok); | |||
| /* PGPRO-5255: check ALTER TABLE IF EXISTS of non existent table */ | |||
There was a problem hiding this comment.
Probably, I'd not use problem numbers here. Otherwise all the code would look like this in near future. Just simple description why this code is here would be enough.
sql/pathman_utility_stmt.sql
Outdated
| * Test, that ALTER TABLE IF EXISTS ... RENAME TO of not existed table generate NOTICE instead of ERROR | ||
| */ | ||
| CREATE SCHEMA rename_nonexistent; | ||
| ALTER TABLE IF EXISTS rename_nonexistent.nonexistent_table RENAME TO other_table_name; |
There was a problem hiding this comment.
Maybe add some more cases here?
ALTER TABLE IF EXISTS foo SET SCHEMA baz;
ALTER TABLE IF EXISTS foo RENAME COLUMN baz TO bar;
DROP TABLE IF EXISTS foo;```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ted table generate ERROR instead of NOTICE