Fixes related to new changes in PostgreSQL 16: December 6, 2022 - December 27, 2022 #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags: pg_pathman Caused by: - ad86d159b6: Add 'missing_ok' argument to build_attrmap_by_name - a61b1f7482: Rework query relation permission checking - b5d6382496: Provide per-table permissions for vacuum and analyze
See the commit 858e776c84f48841e7e16fba7b690b76e54f3675 (Convert the reg* input functions to report (most) errors softly.) in PostgreSQL 16. The function qualified_relnames_to_rangevars is used in the functions create_hash_partitions_internal and create_range_partitions_internal. It looks like these functions should not skip partition names (e.g. in the functions create_hash_partitions and create_range_partitions respectively)..
See the commit 60684dd834a222fefedd49b19d1f0a6189c1632e (Add grantable MAINTAIN privilege and pg_maintain role.) in PostgreSQL 16. Since pathman_permissions_1.out is already in use for PostgreSQL 16+ (see the commit 47806e7 [PGPRO-7585] Fixes for v16 due to vanilla changes), do not create pathman_permissions_2.out.
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 30 30
Lines 6735 6736 +1
=======================================
+ Hits 6224 6225 +1
Misses 511 511
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit 858e776c84f48841e7e16fba7b690b76e54f3675 (Convert the reg* input functions to report (most) errors softly.) in PostgreSQL 16.
The function qualified_relnames_to_rangevars is used in the functions create_hash_partitions_internal and create_range_partitions_internal. It looks like these functions should not skip partition names (e.g. in the functions create_hash_partitions and create_range_partitions respectively)..
See the commit 60684dd834a222fefedd49b19d1f0a6189c1632e (Add grantable MAINTAIN privilege and pg_maintain role.) in PostgreSQL 16.
Since pathman_permissions_1.out is already in use for PostgreSQL 16+ (see the commit 47806e7 [PGPRO-7585] Fixes for v16 due to vanilla changes), do not create pathman_permissions_2.out.