Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 0b8ea70

Browse files
committed
Enable TAP tests of pg_receivewal for ZLIB on Windows, take three
This reverts commit 6a2c532. fairywren and bowerbird failed those tests because of incorrect versions of ZLIB linked to, causing errors like SIGBREAKs that stopped buildfarm runs or EACCES failures when writing compressed WAL segments. Andrew Dunstan has done all the investigation here, so he deserves all the credit for being able to enable those tests on Windows. Discussion: https://postgr.es/m/9040d5ed-6462-66a4-07ac-2923785ae563@dunslane.net
1 parent 14d474e commit 0b8ea70

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/bin/pg_basebackup/t/020_pg_receivewal.pl

+3-5
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,11 @@
7272
my @partial_wals = glob "$stream_dir/*\.partial";
7373
is(scalar(@partial_wals), 1, "one partial WAL segment was created");
7474

75-
# Check ZLIB compression if available. On Windows, some old versions
76-
# of zlib can cause some instabilities with this test, so disable it
77-
# for now.
75+
# Check ZLIB compression if available.
7876
SKIP:
7977
{
80-
skip "postgres was not built with ZLIB support, or Windows is involved", 5
81-
if (!check_pg_config("#define HAVE_LIBZ 1") || $windows_os);
78+
skip "postgres was not built with ZLIB support", 5
79+
if (!check_pg_config("#define HAVE_LIBZ 1"));
8280

8381
# Generate more WAL worth one completed, compressed, segment.
8482
$primary->psql('postgres', 'SELECT pg_switch_wal();');

0 commit comments

Comments
 (0)