Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 6a2c532

Browse files
committed
Disable TAP tests of pg_receivewal for ZLIB on Windows
This reverts commit 91d395f, to avoid running those tests on Windows. The tests are globally stable across all buildfarm members, except fairywren (crash of pg_receivewal) and bowerdird (SIGBREAK preventing the buildfarm run to complete). Those errors are rather strange, as other hosts with very similar characteristics are able to run those tests without breaking a sweat. For now, disable those tests on Windows to turn back the buildfarm to green. Per discussion with Andrew Dunstan. Discussion: https://postgr.es/m/9040d5ed-6462-66a4-07ac-2923785ae563@dunslane.net
1 parent 0207d5f commit 6a2c532

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/bin/pg_basebackup/t/020_pg_receivewal.pl

+5-3
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,13 @@
7272
my @partial_wals = glob "$stream_dir/*\.partial";
7373
is(scalar(@partial_wals), 1, "one partial WAL segment was created");
7474

75-
# Check ZLIB compression if available.
75+
# Check ZLIB compression if available. On Windows, some old versions
76+
# of zlib can cause some instabilities with this test, so disable it
77+
# for now.
7678
SKIP:
7779
{
78-
skip "postgres was not built with ZLIB support", 5
79-
if (!check_pg_config("#define HAVE_LIBZ 1"));
80+
skip "postgres was not built with ZLIB support, or Windows is involved", 5
81+
if (!check_pg_config("#define HAVE_LIBZ 1") || $windows_os);
8082

8183
# Generate more WAL worth one completed, compressed, segment.
8284
$primary->psql('postgres', 'SELECT pg_switch_wal();');

0 commit comments

Comments
 (0)