Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 4b763ff

Browse files
committed
Remove seemingly unneeded include directory in MSVC scripts
This appears to have been added way back in ee3b418 but it's a little unclear why the change made in that commit is even needed given that 320c7eb, dated 18 months earlier, added code to copy fmgroids.h to src/include/utils. amcheck seems to get away without adding the additional include directory, so perhaps dblink can get away with it too. This builds ok in my VS2017 environment, but the buildfarm may serve as a reminder about why ee3b418 was required. There's only one way to find out for sure. Discussion: https://postgr.es/m/CAApHDvpo6g5csCTjc_0C7DMvgFPomVb0Rh-AcW5afd=Ya=LRuw@mail.gmail.com
1 parent 93a0bf2 commit 4b763ff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/tools/msvc/Mkvcbuild.pm

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ my @contrib_uselibpq =
4141
my @contrib_uselibpgport = ('libpq_pipeline', 'oid2name', 'vacuumlo');
4242
my @contrib_uselibpgcommon = ('libpq_pipeline', 'oid2name', 'vacuumlo');
4343
my $contrib_extralibs = { 'libpq_pipeline' => ['ws2_32.lib'] };
44-
my $contrib_extraincludes = { 'dblink' => ['src/backend'] };
44+
my $contrib_extraincludes = {};
4545
my $contrib_extrasource = {
4646
'cube' => [ 'contrib/cube/cubescan.l', 'contrib/cube/cubeparse.y' ],
4747
'seg' => [ 'contrib/seg/segscan.l', 'contrib/seg/segparse.y' ],

0 commit comments

Comments
 (0)