Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 8a2b1b1

Browse files
committed
bufmgr: Remove buffer-write-dirty tracepoints
The trace point was using the relfileno / fork / block for the to-be-read-in buffer. Some upcoming work would make that more expensive to provide. We still have buffer-flush-start/done, which can serve most tracing needs that buffer-write-dirty could serve. Discussion: https://postgr.es/m/f5164e7a-eef6-8972-75a3-8ac622ed0c6e@iki.fi
1 parent 05a304a commit 8a2b1b1

File tree

3 files changed

+0
-29
lines changed

3 files changed

+0
-29
lines changed

doc/src/sgml/monitoring.sgml

-17
Original file line numberDiff line numberDiff line change
@@ -7817,23 +7817,6 @@ FROM pg_stat_get_backend_idset() AS backendid;
78177817
it's typically not actually been written to disk yet.)
78187818
The arguments are the same as for <literal>buffer-flush-start</literal>.</entry>
78197819
</row>
7820-
<row>
7821-
<entry><literal>buffer-write-dirty-start</literal></entry>
7822-
<entry><literal>(ForkNumber, BlockNumber, Oid, Oid, Oid)</literal></entry>
7823-
<entry>Probe that fires when a server process begins to write a dirty
7824-
buffer. (If this happens often, it implies that
7825-
<xref linkend="guc-shared-buffers"/> is too
7826-
small or the background writer control parameters need adjustment.)
7827-
arg0 and arg1 contain the fork and block numbers of the page.
7828-
arg2, arg3, and arg4 contain the tablespace, database, and relation OIDs
7829-
identifying the relation.</entry>
7830-
</row>
7831-
<row>
7832-
<entry><literal>buffer-write-dirty-done</literal></entry>
7833-
<entry><literal>(ForkNumber, BlockNumber, Oid, Oid, Oid)</literal></entry>
7834-
<entry>Probe that fires when a dirty-buffer write is complete.
7835-
The arguments are the same as for <literal>buffer-write-dirty-start</literal>.</entry>
7836-
</row>
78377820
<row>
78387821
<entry><literal>wal-buffer-write-dirty-start</literal></entry>
78397822
<entry><literal>()</literal></entry>

src/backend/storage/buffer/bufmgr.c

-10
Original file line numberDiff line numberDiff line change
@@ -1280,21 +1280,11 @@ BufferAlloc(SMgrRelation smgr, char relpersistence, ForkNumber forkNum,
12801280
}
12811281

12821282
/* OK, do the I/O */
1283-
TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_START(forkNum, blockNum,
1284-
smgr->smgr_rlocator.locator.spcOid,
1285-
smgr->smgr_rlocator.locator.dbOid,
1286-
smgr->smgr_rlocator.locator.relNumber);
1287-
12881283
FlushBuffer(buf, NULL, IOOBJECT_RELATION, io_context);
12891284
LWLockRelease(BufferDescriptorGetContentLock(buf));
12901285

12911286
ScheduleBufferTagForWriteback(&BackendWritebackContext,
12921287
&buf->tag);
1293-
1294-
TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_DONE(forkNum, blockNum,
1295-
smgr->smgr_rlocator.locator.spcOid,
1296-
smgr->smgr_rlocator.locator.dbOid,
1297-
smgr->smgr_rlocator.locator.relNumber);
12981288
}
12991289
else
13001290
{

src/backend/utils/probes.d

-2
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ provider postgresql {
6666
probe buffer__sync__start(int, int);
6767
probe buffer__sync__written(int);
6868
probe buffer__sync__done(int, int, int);
69-
probe buffer__write__dirty__start(ForkNumber, BlockNumber, Oid, Oid, Oid);
70-
probe buffer__write__dirty__done(ForkNumber, BlockNumber, Oid, Oid, Oid);
7169

7270
probe deadlock__found();
7371

0 commit comments

Comments
 (0)