Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 9df2a4b

Browse files
committed
Add missing BUFFERS OFF in regression tests, take 2
Similar to 9fa1aaa, but running with -D RELCACHE_FORCE_RELEASE and -D CATCACHE_FORCE_RELEASE yielded some additional missing places that needed BUFFERS OFF. Discussion: https://postgr.es/m/CANNMO++W7MM8T0KyXN3ZheXXt-uLVM3aEtZd+WNfZ=obxffUiA@mail.gmail.com
1 parent 9fa1aaa commit 9df2a4b

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

src/test/regress/expected/matview.out

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ GRANT ALL ON SCHEMA matview_schema TO public;
624624
SET SESSION AUTHORIZATION regress_matview_user;
625625
CREATE MATERIALIZED VIEW matview_schema.mv_withdata1 (a) AS
626626
SELECT generate_series(1, 10) WITH DATA;
627-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
627+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
628628
CREATE MATERIALIZED VIEW matview_schema.mv_withdata2 (a) AS
629629
SELECT generate_series(1, 10) WITH DATA;
630630
QUERY PLAN
@@ -636,7 +636,7 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
636636
REFRESH MATERIALIZED VIEW matview_schema.mv_withdata2;
637637
CREATE MATERIALIZED VIEW matview_schema.mv_nodata1 (a) AS
638638
SELECT generate_series(1, 10) WITH NO DATA;
639-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
639+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
640640
CREATE MATERIALIZED VIEW matview_schema.mv_nodata2 (a) AS
641641
SELECT generate_series(1, 10) WITH NO DATA;
642642
QUERY PLAN
@@ -669,23 +669,23 @@ ERROR: relation "matview_ine_tab" already exists
669669
CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS
670670
SELECT 1 / 0 WITH NO DATA; -- ok
671671
NOTICE: relation "matview_ine_tab" already exists, skipping
672-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
672+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
673673
CREATE MATERIALIZED VIEW matview_ine_tab AS
674674
SELECT 1 / 0; -- error
675675
ERROR: relation "matview_ine_tab" already exists
676-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
676+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
677677
CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS
678678
SELECT 1 / 0; -- ok
679679
NOTICE: relation "matview_ine_tab" already exists, skipping
680680
QUERY PLAN
681681
------------
682682
(0 rows)
683683

684-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
684+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
685685
CREATE MATERIALIZED VIEW matview_ine_tab AS
686686
SELECT 1 / 0 WITH NO DATA; -- error
687687
ERROR: relation "matview_ine_tab" already exists
688-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
688+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
689689
CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS
690690
SELECT 1 / 0 WITH NO DATA; -- ok
691691
NOTICE: relation "matview_ine_tab" already exists, skipping

src/test/regress/expected/misc_functions.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ BEGIN
2222
SET LOCAL jit = 0;
2323

2424
FOR ln IN
25-
EXECUTE format('explain (analyze %s, costs on, summary off, timing off) %s',
25+
EXECUTE format('explain (analyze %s, costs on, summary off, timing off, buffers off) %s',
2626
analyze_str, query)
2727
LOOP
2828
IF hide_costs = true THEN

src/test/regress/sql/matview.sql

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -274,13 +274,13 @@ GRANT ALL ON SCHEMA matview_schema TO public;
274274
SET SESSION AUTHORIZATION regress_matview_user;
275275
CREATE MATERIALIZED VIEW matview_schema.mv_withdata1 (a) AS
276276
SELECT generate_series(1, 10) WITH DATA;
277-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
277+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
278278
CREATE MATERIALIZED VIEW matview_schema.mv_withdata2 (a) AS
279279
SELECT generate_series(1, 10) WITH DATA;
280280
REFRESH MATERIALIZED VIEW matview_schema.mv_withdata2;
281281
CREATE MATERIALIZED VIEW matview_schema.mv_nodata1 (a) AS
282282
SELECT generate_series(1, 10) WITH NO DATA;
283-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
283+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
284284
CREATE MATERIALIZED VIEW matview_schema.mv_nodata2 (a) AS
285285
SELECT generate_series(1, 10) WITH NO DATA;
286286
REFRESH MATERIALIZED VIEW matview_schema.mv_nodata2;
@@ -301,16 +301,16 @@ CREATE MATERIALIZED VIEW matview_ine_tab AS
301301
SELECT 1 / 0 WITH NO DATA; -- error
302302
CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS
303303
SELECT 1 / 0 WITH NO DATA; -- ok
304-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
304+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
305305
CREATE MATERIALIZED VIEW matview_ine_tab AS
306306
SELECT 1 / 0; -- error
307-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
307+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
308308
CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS
309309
SELECT 1 / 0; -- ok
310-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
310+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
311311
CREATE MATERIALIZED VIEW matview_ine_tab AS
312312
SELECT 1 / 0 WITH NO DATA; -- error
313-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
313+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
314314
CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS
315315
SELECT 1 / 0 WITH NO DATA; -- ok
316316
DROP MATERIALIZED VIEW matview_ine_tab;

src/test/regress/sql/misc_functions.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ BEGIN
2424
SET LOCAL jit = 0;
2525

2626
FOR ln IN
27-
EXECUTE format('explain (analyze %s, costs on, summary off, timing off) %s',
27+
EXECUTE format('explain (analyze %s, costs on, summary off, timing off, buffers off) %s',
2828
analyze_str, query)
2929
LOOP
3030
IF hide_costs = true THEN

0 commit comments

Comments
 (0)