Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit baa1ae0

Browse files
committed
injection_points: Improve comment about disabled isolation permutation
9f00edc has disabled a permutation due to failures in the CI for FreeBSD environments, but this is a matter of timing. Let's document properly why this type of permutation is a bad idea if relying on a wait done in a SQL function, so as this can be avoided when implementing new tests (this spec is also a template). Reviewed-by: Bertrand Drouvot Discussion: https://postgr.es/m/ZyCa2qsopKaw3W3K@paquier.xyz
1 parent 492e6b5 commit baa1ae0

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/test/modules/injection_points/specs/basic.spec

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ step wakeup2 { SELECT injection_points_wakeup('injection-points-wait'); }
2626
step detach2 { SELECT injection_points_detach('injection-points-wait'); }
2727

2828
# Detach after wait and wakeup.
29-
# This permutation is proving to be unstable on FreeBSD, so disable for now.
29+
# Permutations like the following one commented out should be avoided, as
30+
# the detach may finish before the SQL function doing the wait returns
31+
# its result. It is recommended to use wakeups as the last permutation
32+
# should a wait be done within an SQL function.
3033
#permutation wait1 wakeup2 detach2
3134

3235
# Detach before wakeup. s1 waits until wakeup, ignores the detach.

0 commit comments

Comments
 (0)