Fix ??? comment about JsonAnalyzeContext.scalarsOnly

Nikita Glukhov · Nikita Glukhov · commit c8d6c9c799a3 · 2022-01-23T01:00:51.000+03:00
diff --git a/src/backend/utils/adt/jsonb_typanalyze.c b/src/backend/utils/adt/jsonb_typanalyze.c
@@ -343,7 +343,7 @@ jsonAnalyzeJsonValue(JsonAnalyzeContext *ctx, JsonValueStats *vstats,
 	JsonbValue			jbvtmp;
 	Datum				value;
 
-	/* ??? */
+	/* XXX if analyzing only scalar values, make containers empty */
 	if (ctx->scalarsOnly && jv->type == jbvBinary)
 	{
 		if (JsonContainerIsObject(jv->val.binary.data))

Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,7 @@ jsonAnalyzeJsonValue(JsonAnalyzeContext ctx, JsonValueStats vstats,`
`343`	`343`	`JsonbValue jbvtmp;`
`344`	`344`	`Datum value;`
`345`	`345`
`346`		`- /* ??? */`
	`346`	`+ /* XXX if analyzing only scalar values, make containers empty */`
`347`	`347`	`if (ctx->scalarsOnly && jv->type == jbvBinary)`
`348`	`348`	`{`
`349`	`349`	`if (JsonContainerIsObject(jv->val.binary.data))`