Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master_ci
Choose a base branch
from
Open

Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
507a6ed
Allow REINDEX to change tablespace
ololobus Mar 23, 2020
7acd35b
Specially handle toast relations during REINDEX.
Mar 9, 2020
692bcad
Allow CLUSTER and VACUUM FULL to change tablespace
ololobus Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Specially handle toast relations during REINDEX. 
Is this fine ?  It says "cannot reindex system catalogs concurrently" (once),
and hits the pg_toast tables for information_schema.  Should it skip toast
indexes (like it said) ?  Or should it REINDEX them on the same tablespace?

template1=# REINDEX DATABASE CONCURRENTLY template1 TABLESPACE pg_default;
2020-03-09 15:33:51.792 CDT [6464] WARNING:  cannot reindex system catalogs concurrently, skipping all
WARNING:  cannot reindex system catalogs concurrently, skipping all
2020-03-09 15:33:51.794 CDT [6464] WARNING:  skipping tablespace change of "pg_toast_12558_index"
2020-03-09 15:33:51.794 CDT [6464] DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
WARNING:  skipping tablespace change of "pg_toast_12558_index"
DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
2020-03-09 15:33:51.924 CDT [6464] WARNING:  skipping tablespace change of "pg_toast_12543_index"
2020-03-09 15:33:51.924 CDT [6464] DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
WARNING:  skipping tablespace change of "pg_toast_12543_index"
DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
2020-03-09 15:33:51.982 CDT [6464] WARNING:  skipping tablespace change of "pg_toast_12548_index"
2020-03-09 15:33:51.982 CDT [6464] DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
WARNING:  skipping tablespace change of "pg_toast_12548_index"
DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
2020-03-09 15:33:52.048 CDT [6464] WARNING:  skipping tablespace change of "pg_toast_12553_index"
2020-03-09 15:33:52.048 CDT [6464] DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
WARNING:  skipping tablespace change of "pg_toast_12553_index"
DETAIL:  Cannot move system relation, only REINDEX CONCURRENTLY is performed.
REINDEX
  • Loading branch information
@ololobus
Justin Pryzby authored and ololobus committed Mar 26, 2020
commit 7acd35b700d53cee585dd5ef7501f9c079a1649a
20 changes: 16 additions & 4 deletions src/backend/catalog/index.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3474,11 +3474,23 @@ reindex_index(Oid indexId, Oid tablespaceOid, bool skip_constraint_checks,
RelationGetRelationName(iRel));

/*
* We don't support moving system relations into different tablespaces,
* unless allow_system_table_mods=1.
* Skip tablespace change of all indexes on TOAST tables, unless
* allow_system_table_mods=1, but error out on system catalog.
*/
if (set_tablespace &&
!allowSystemTableMods && IsSystemRelation(iRel))
if (set_tablespace && IsToastRelation(iRel))
{
if (!allowSystemTableMods)
{
ereport(WARNING,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("skipping tablespace change of \"%s\"",
RelationGetRelationName(iRel)),
errdetail("Cannot move system relation, only REINDEX is performed.")));
set_tablespace = false;
}
}
else if (set_tablespace &&
IsCatalogRelationOid(indexId) && !allowSystemTableMods)
ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("permission denied: \"%s\" is a system catalog",
Expand Down
20 changes: 12 additions & 8 deletions src/backend/commands/indexcmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3061,14 +3061,17 @@ ReindexRelationConcurrently(Oid relationOid, Oid tablespaceOid, int options)

/*
* We don't support moving system relations into different tablespaces,
* unless allow_system_table_mods=1.
* unless allow_system_table_mods=1. Reindexing concurrently is not
* allowed for system catalog, so we only check for indexes on
* TOAST tables here.
*/
if (OidIsValid(tablespaceOid) &&
!allowSystemTableMods && IsSystemRelation(indexRel))
ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("permission denied: \"%s\" is a system catalog",
RelationGetRelationName(indexRel))));
if (OidIsValid(tablespaceOid)
&& IsToastRelation(indexRel) && !allowSystemTableMods)
ereport(WARNING,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("skipping tablespace change of \"%s\"",
RelationGetRelationName(indexRel)),
errdetail("Cannot move system relation, only REINDEX CONCURRENTLY is performed.")));

/*
* We cannot support moving mapped relations into different tablespaces.
Expand Down Expand Up @@ -3099,7 +3102,8 @@ ReindexRelationConcurrently(Oid relationOid, Oid tablespaceOid, int options)
/* Create new index definition based on given index */
newIndexId = index_concurrently_create_copy(heapRel,
indexId,
tablespaceOid,
IsToastRelation(indexRel) && !allowSystemTableMods ?
InvalidOid : tablespaceOid,
concurrentName);

/*
Expand Down