PostgresNode_Base is added #222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This base class requires: - explicit os_ops object This base class declares the following abstract properties: - logs_dir - data_dir - utils_log_file - pg_log_file
Merged
This thing is required only in the constructor of PostgresNode.
PostgresNode_Base::clean deletes data_dir and logs_dir PostgresNode::clean calls PostgresNode_Base::clean and deletes base_dir.
Names from 'utils' module are used explicitly.
Names from 'consts' module are used explicitly.
- [del] import of PG_CTL__STATUS__OK - [del] import of PG_CTL__STATUS__NODE_IS_STOPPED - [del] PG_CTL__STATUS__BAD_DATADIR
[del] node.should_rm_dirs=True
The problems on Probackup's CFS test are detected. Parameter 'full' must be respected!
It a right way for creating a clone of PostgresNode.
|
I think, this refactoring is not actual now. I always can create it again, when it will be needed really. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This base class requires:
This base class declares the following "abstract" properties:
This thing is needed for #216 and should help to #184.