Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

A support of Python v3.8 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmitry-lipetsk
Copy link
Collaborator

@dmitry-lipetsk dmitry-lipetsk commented Apr 8, 2025

Python 3.8 does not support list[...], tuple[...], set[...] and so on.

These types were replaced with types from typing. It works in all the versions of python.

Also
This PR is adding into CI a verification for Python 3.8.0, 3.8, 3.9, 3.10 and 3.11.

Python 3.8 does not support tuple[...], list[...], set[...] and so on.

We will use the analogues from typing package: typing.Tuple[...], typing.List[...] and typing.Set[...].
This commit fixes a problem with imports.

As I understand 3.8 has a problem with import across root-directory and I do not know/find how to fix it correctly.

If someone know how to resolve these problems more easily (through sys.path/__init__.py?) - you are welcome!
We will run all the tests to get a full information about compatibility.

Some new tests may fail.

---
TODO: may be it is better to compile/install required python version explicitly instead using pyenv.
This reverts commit 96ddf19.

It seems to me there was a local gluk. Let's test without these changes.
@dmitry-lipetsk dmitry-lipetsk merged commit 2401474 into postgrespro:master Apr 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant