commit=True by default in PostgresNode.execute() and document it. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old default could lead to astonishing "where are my damned rows?" emotions.
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 93.79% 93.79%
=======================================
Files 4 4
Lines 773 773
=======================================
Hits 725 725
Misses 48 48
Continue to review full report at Codecov.
|
funbringer
reviewed
Nov 16, 2017
| @@ -962,7 +962,7 @@ def poll_query_until(self, | |||
|
|
|||
| raise TimeoutException('Query timeout') | |||
|
|
|||
| def execute(self, dbname, query, username=None, commit=False): | |||
| def execute(self, dbname, query, username=None, commit=True): | |||
There was a problem hiding this comment.
@funbringer у меня нет, тем более я всегда делал вручную, без параметра
|
Nice one, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old default could lead to astonishing "where are my damned rows?" emotions.