Add PostgresNode.__repr__() method #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funbringer
requested changes
Mar 21, 2018
testgres/api.py
Outdated
| @@ -7,27 +7,27 @@ | |||
| edit configuration files, start/stop cluster, execute queries. The | |||
| typical flow may look like: | |||
|
|
|||
| >>> with get_new_node() as node: | |||
| >>> with get_new_node('test') as node: | |||
There was a problem hiding this comment.
IMHO it's better to have at least one example with no args at all. It would show user that literally every arg of get_new_node() has a decent default.
testgres/api.py
Outdated
| ... node.init().start() | ||
| ... result = node.safe_psql('postgres', 'select 1') | ||
| ... print(result.decode('utf-8').strip()) | ||
| ... node.stop() | ||
| <testgres.node.PostgresNode object at 0x...> | ||
| PostgresNode('test', port=..., base_dir=...) |
There was a problem hiding this comment.
I believe that 'test' should be prefixed by name=.
There was a problem hiding this comment.
I personally disagree as it makes the whole output 5 symbols larger, but I can make my peace with that : )
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 97.23% 97.29% +0.05%
==========================================
Files 16 16
Lines 1340 1368 +28
==========================================
+ Hits 1303 1331 +28
Misses 37 37
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because current string representation of
PostgresNodedoesn't make much sense. Now it looks something like:Also fixed some examples in comments so that they pass
doctest.