Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Add **kwargs to append_conf() #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2018

Conversation

funbringer
Copy link
Collaborator

This would allow us to do the following:

from testgres import get_new_node

node = testgres.get_new_node(port=5432).init().start()
node.append_conf(fsync=False, random_page_cost=1.5)

@funbringer funbringer requested review from zilder and ildus June 5, 2018 11:22
self.host,
self.port)) # yapf: disable
# common replication settings
if allow_streaming or allow_logical:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to fix settings according to this page.

@funbringer funbringer changed the title Add **kwargs to append_conf() Add **kwargs to append_conf() Jun 5, 2018
@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #48 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   97.02%   97.17%   +0.14%     
==========================================
  Files          17       17              
  Lines        1547     1556       +9     
==========================================
+ Hits         1501     1512      +11     
+ Misses         46       44       -2
Impacted Files Coverage Δ
testgres/consts.py 100% <100%> (ø) ⬆️
tests/test_simple.py 99.81% <100%> (+0.37%) ⬆️
testgres/node.py 97.05% <100%> (+0.05%) ⬆️
testgres/backup.py 96.96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a8f1a...e461f59. Read the comment docs.

@funbringer funbringer merged commit 66ca763 into postgrespro:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants