gh-174: Support free-threading CPython by disabling psutil related fe…#175
gh-174: Support free-threading CPython by disabling psutil related fe…#175
Conversation
|
cc @colesbury |
pyperf/_utils.py
Outdated
| from shutil import which | ||
|
|
||
|
|
||
| IS_FREE_THREADING = bool(sysconfig.get_config_var('Py_GIL_DISABLED')) |
There was a problem hiding this comment.
I suggest to remove IS_: just FREE_THREADING.
vstinner
left a comment
There was a problem hiding this comment.
Can't we get psutil fixed instead of having such workaround?
| Version 2.6.3 (2024-03-05) | ||
| --------------------------- | ||
|
|
||
| * Support Free-threading CPython (PEP-703) by disabling psutil related features. |
There was a problem hiding this comment.
Please add a link to the issue.
There was a problem hiding this comment.
The current blocker is pypa/packaging#755, but there's ~3 more steps needed after that too (update packaging in pip, release pip, update pip in CPython).
There was a problem hiding this comment.
The issue describing why pyperf cannot use psutil on a Python Free Threading build.
It's not related to psutil implementation itself, it is more about packaging issue for a while. |
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I just have a last comment about the comments :-)
|
@vstinner Would you like to take a look the PR again? |
…atures