add ini option to disable string escape for parametrization #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/_pytest/python.py
Outdated
| @@ -1177,7 +1194,7 @@ def _idval(val, argname, idx, idfn, item, config): | |||
| return hook_id | |||
|
|
|||
| if isinstance(val, STRING_TYPES): | |||
| return ascii_escaped(val) | |||
| return _ascii_escaped_by_config(val) | |||
There was a problem hiding this comment.
without passing config, this is useless
There was a problem hiding this comment.
Thanks, I fixed it
Codecov Report
@@ Coverage Diff @@
## features #4995 +/- ##
============================================
+ Coverage 95.98% 95.98% +<.01%
============================================
Files 113 113
Lines 25381 25387 +6
Branches 2503 2504 +1
============================================
+ Hits 24361 24367 +6
Misses 714 714
Partials 306 306
Continue to review full report at Codecov.
|
nicoddemus
reviewed
Mar 25, 2019
nicoddemus
reviewed
Mar 25, 2019
nicoddemus
approved these changes
Mar 25, 2019
nicoddemus
approved these changes
Mar 27, 2019
|
Thanks a lot for this @youknowone! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2482
Cherry-picked and rebased #2830
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORSin alphabetical order;cc @ApaDoctor