gh-128894: Fix TracebackException._format_syntax_error on custom SyntaxError metadata
#128946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or` on custom `SyntaxError` metadata
iritkatriel
approved these changes
Jan 17, 2025
pablogsal
approved these changes
Jan 22, 2025
|
Thanks @sobolevn for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 22, 2025
…tom `SyntaxError` metadata (pythonGH-128946) (cherry picked from commit a16ded1) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-129178 is a backport of this pull request to the 3.13 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding type checks solved the problem, while still producing readable errors.
raise SyntaxError('hello', 'abcdef')crashes the new Python 3.13 REPL #128894