Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91048: fix thread safety for asyncio stack introspection APIs #129399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-91048: fix thread safety for asyncio stack introspection APIs #129399

wants to merge 1 commit into from
+124 −99

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 28, 2025 •
edited
Loading

Changes:

  • Add critical sections where required before calling impl function
  • Add critical section assertions
  • Move getters setters to be together with others
  • Elide away unnecessary type checks and align functions to take FutureObj * as all the other ones already do. In most cases, we avoid type checking on task which is guaranteed to be task or its subclass.

@bedevere-app bedevere-app bot mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@ambv ambv Awaiting requested review from ambv

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
awaiting core review skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kumaraditya303