gh-141388: Fully support non-function callables as annotate functions#141449
Closed
dr-carlos wants to merge 33 commits intopython:mainfrom
Closed
gh-141388: Fully support non-function callables as annotate functions#141449dr-carlos wants to merge 33 commits intopython:mainfrom
dr-carlos wants to merge 33 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__annotate__function in 3.14, butannotationlibwill start throwing errors if the format is not implemented.call_annotate_function()__code__,__globals__, etc., so aForwardRefor stringification using the current techniques is impossible. Let me know if there are any more callables to implement, some more special-casing will probably be required.annotationlib, but tests are mostly present oncall_annotate_function()for now.__annotate__Functions don't actually need to be functions #141388