Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

[3.7] bpo-37400: Fix test_os.test_chown() (GH-14374)#14378

Merged
vstinner merged 1 commit intopython:3.7from
miss-islington:backport-d7c87d9-3.7
Jun 25, 2019
Merged

[3.7] bpo-37400: Fix test_os.test_chown() (GH-14374)#14378
vstinner merged 1 commit intopython:3.7from
miss-islington:backport-d7c87d9-3.7

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 25, 2019

Use os.getgroups() rather than grp.getgrall() to get groups.
Rename also the test to test_chown_gid().
(cherry picked from commit d7c87d9)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37400

Use os.getgroups() rather than grp.getgrall() to get groups.
Rename also the test to test_chown_gid().
(cherry picked from commit d7c87d9)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

@vstinner vstinner merged commit 1d4b6ba into python:3.7 Jun 25, 2019
@miss-islington miss-islington deleted the backport-d7c87d9-3.7 branch June 25, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants