Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

gh-141510: Avoid critical section on frozendict copy#145920

Open
vstinner wants to merge 2 commits intopython:mainfrom
vstinner:optim_frozendict_copy
Open

gh-141510: Avoid critical section on frozendict copy#145920
vstinner wants to merge 2 commits intopython:mainfrom
vstinner:optim_frozendict_copy

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Mar 13, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 13, 2026
Open
@vstinner
Copy link
Member Author

vstinner commented Mar 13, 2026

cc @corona10

clin1234
clin1234 reviewed Mar 13, 2026
View reviewed changes
Copy link
Contributor

@clin1234 clin1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, LGTM, though I am curious about concurrency safety in eliding a critical section when copying a frozendict, especially with a free-threaded interpreter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

+1 more reviewer

@clin1234 clin1234 clin1234 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @corona10 @clin1234