gh-146031: Allow keeping specialization enabled when specifying eval frame function#146032
Open
DinoV wants to merge 2 commits intopython:mainfrom
Open
gh-146031: Allow keeping specialization enabled when specifying eval frame function#146032DinoV wants to merge 2 commits intopython:mainfrom
DinoV wants to merge 2 commits intopython:mainfrom
Conversation
2073854 to
3adb88b
Compare
3adb88b to
3c76262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An eval frame evaluator doesn't necessarily want to disable specialization of Python -> Python calls... The custom eval frame can either hook the specializing functions its self or they can specify vectorcall on a function object which prevents the nested dispatch.
This adds an argument to
_PyInterpreterState_SetEvalFrameFuncwhich allows the specification of whether or not specialization should be allowed. Setting it to 1 will allow the specializer to optimize Python -> Python calls. It's up to the eval frame replacement to make sure that this will work for them.📚 Documentation preview 📚: https://cpython-previews--146032.org.readthedocs.build/