bpo-31677: email: Add re.ASCII when re.IGNORECASE is used#3868
Merged
methane merged 2 commits intopython:masterfrom Oct 4, 2017
Merged
bpo-31677: email: Add re.ASCII when re.IGNORECASE is used#3868methane merged 2 commits intopython:masterfrom
methane merged 2 commits intopython:masterfrom
Conversation
While there is not real bug in this case, using re.ASCII is safe when re.IGNORECASE is used. This commit removes dead copy in email.util too.
warsaw
approved these changes
Oct 3, 2017
Member
warsaw
left a comment
There was a problem hiding this comment.
LGTM! Thanks for removing the dead code too.
bitdancer
approved these changes
Oct 3, 2017
| \? # literal ? | ||
| (?P<atom>.*?) # non-greedy up to the next ?= is the atom | ||
| \?= # literal ?= | ||
| ''', re.VERBOSE | re.IGNORECASE) |
Member
There was a problem hiding this comment.
This was probably left in place for backward compatibility reasons (just in case someone was using it). Or it may have been overlooked. No way to tell :) But, probably better to not delete it if you backport this change.
Member
Author
There was a problem hiding this comment.
Since this change doesn't actual bugfix (B and Q don't have another lower cases),
I won't backport it to Python 3.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While there is not real bug in this case, using re.ASCII is
safe when re.IGNORECASE is used.
This commit removes dead copy in email.util too.
https://bugs.python.org/issue31677