Const correctness for numerous data provider methods #3291
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks numerous QgsDataProvider, QgsVectorDataProvider and QgsRasterLayer methods correctly as const.
It partly addresses qgis/qgis4.0_api#48
Note that many individual data provider members have been marked as mutable as a consequence - I think this is acceptable, as it's semantically correct. These methods should be marked const, and it's valid to make any cached variables which are altered as a result mutable.